Currently, all methods on the TransactionLibrary have signatures with a gazillion primitives. Yet several (all?) build a message object and push it through a pipline, and then does a few infrastructural things like assigning associations and saving.

I'd really like to just pass the message object already instead of passing primitives. Even with our own view model, it'd be easier to use AutoMapper for instance instead of passing each and every property. Not to mention mind which ones we actually use. (What's all these nulls in that method call?)

An example would be EditBillingInformation. I'd really like an overload where I can just pass the AddAddressRequest object. It'd be fine if the method assigns the existing address and purchase order. Or even separate those two "infrastructural bits" from the concrete "message" or "command".

(Ref. Clean Code, Refactoring & other nice books - more than three arguments for a method is too many. Refactor them in to a parameter class. ;) )

Hey guys, we are dealing with a problem here while trying to edit/remove product definitions:

1. Go to Commerce Settings / Product Definitions and create a new definition
2. Go to sitecore Content Editor and check for the two new templates that were created just fine.
3. Then we try to edit those templates by updating the layout and/or sub-layouts at the standard values item and save the changes.
4. Then open up the presentation/details again and you will notice no changes at sight, meaning no changes were saved.
5. Then go to the commerce settings/products definitions again and remove the new created item there.
6. Then go back to sitecore content editor and you will see the two templates are still there.
7. Then try to remove them manually and you will notice nothing happens.

So wondering if it could be something going wrong with unicorn or is there something else?

We are working with:

- Sitecore.NET 8.2 (rev. 161221)
- uCommerce-for-Sitecore-7.5.0.17040
- Latest code pulled from https://bitbucket.org/uCommerce/avenue-clothing-for-sitecore

Any thoughts?

Thanks,
Ruben.

Exception when trying to install uCommerce on empty Umbraco instance.
Error when installing is below:
at Umbraco.Core.Cache.HttpRuntimeCacheProvider.GetCacheItem(String cacheKey, Func`1 getCacheItem, Nullable`1 timeout, Boolean isSliding, CacheItemPriority priority, CacheItemRemovedCallback removedCallback, CacheDependency dependency)
at Umbraco.Core.Cache.HttpRuntimeCacheProvider.GetCacheItem(String cacheKey, Func`1 getCacheItem, Nullable`1 timeout, Boolean isSliding, CacheItemPriority priority, CacheItemRemovedCallback removedCallback, String[] dependentFiles)
at Umbraco.Core.Cache.DeepCloneRuntimeCacheProvider.GetCacheItem(String cacheKey, Func`1 getCacheItem, Nullable`1 timeout, Boolean isSliding, CacheItemPriority priority, CacheItemRemovedCallback removedCallback, String[] dependentFiles)
at Umbraco.Core.Services.ApplicationTreeService.GetAppTrees()
at Umbraco.Core.Services.ApplicationTreeService.GetAll()
at umbraco.BusinessLogic.ApplicationTree.getAll()
at umbraco.cms.presentation.Trees.TreeDefinitionCollection.EnsureTreesRegistered()
at Umbraco.Web.Editors.PackageInstallController.CleanUp(PackageInstallModel model)
at lambda_method(Closure , Object , Object[] )
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.<>c__DisplayClass10.<GetExecutor>b__9(Object instance, Object[] methodParameters)
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ExecuteAsync(HttpControllerContext controllerContext, IDictionary`2 arguments, CancellationToken cancellationToken)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Controllers.ApiControllerActionInvoker.<InvokeActionAsyncCore>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.ActionFilterAttribute.<ExecuteActionFilterAsyncCore>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.ActionFilterAttribute.<ExecuteActionFilterAsyncCore>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.ActionFilterAttribute.<ExecuteActionFilterAsyncCore>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Controllers.ActionFilterResult.<ExecuteAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.AuthorizationFilterAttribute.<ExecuteAuthorizationFilterAsyncCore>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.AuthorizationFilterAttribute.<ExecuteAuthorizationFilterAsyncCore>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Filters.AuthorizationFilterAttribute.<ExecuteAuthorizationFilterAsyncCore>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__1.MoveNext()

I’m adding a bit of workflow to the order statuses in a shop.
I was positive there was a few built-in tasks, but I can see I made my own the last time I did this.

Is there really no “ChangeOrderStatus(newId)” or “AdvanceStatus” tasks to just re-use in the castle config?
Would that be a nice addition to the built-in tasks to pick from?

The current process is:
“New order” to either “Processing” or “Changed”.
When “Changed”, the system sends n e-mails, and moves the order back to “Processing”.
This could’ve been set up easily with two bundled tasks, one which we have:

<!-- Need this one -->
<component
id="ChangeStatusTo.Processing"
service="UCommerce.Pipelines.IPipelineTask`1[[UCommerce.EntitiesV2.PurchaseOrder, UCommerce]], UCommerce"
type="UCommerce.Pipelines.Orders.ChangeStatus, UCommerce.Pipelines">
<parameters>
<newStatusId>2</newStatusId>
</parameters>
</component>

<!-- example -->
<component id="ToChanged"
service="UCommerce.Pipelines.IPipeline`1[[UCommerce.EntitiesV2.PurchaseOrder, UCommerce]], UCommerce"
type="UCommerce.Pipelines.Transactions.Orders.OrderProcessingPipeline, UCommerce.Pipelines">
<parameters>
<tasks>
<array>
<value>{{SendEmail.Changed}}</value>
<value>{{ChangeStatusTo.Processing}}</value>
</array>
</tasks>
</parameters>
</component>

While the query-string parameter names "Catalog", "Category", and "Product" are valid, we should be able to control exactly what goes into our paths without making heavy modifications to the system.

If the value for those parameters was controlled in a config file, we would have that ability with minimal required effort. This should also be a very low-effort change to apply to the uCommerce system.

Similarly, the "slug" prefixes in the SEO-friendly URLs for the Catalog, Category, and Product values should also be controllable with minimal effort. These values could also be in a config file, again requiring minimal effort on the end-developer's part and minimal changes to the uCommerce code-base.