Provide overloads with AddAddressRequest etc. to TransactionLibrary
Currently, all methods on the TransactionLibrary have signatures with a gazillion primitives. Yet several (all?) build a message object and push it through a pipline, and then does a few infrastructural things like assigning associations and saving.
I'd really like to just pass the message object already instead of passing primitives. Even with our own view model, it'd be easier to use AutoMapper for instance instead of passing each and every property. Not to mention mind which ones we actually use. (What's all these nulls in that method call?)
An example would be EditBillingInformation. I'd really like an overload where I can just pass the AddAddressRequest object. It'd be fine if the method assigns the existing address and purchase order. Or even separate those two "infrastructural bits" from the concrete "message" or "command".
(Ref. Clean Code, Refactoring & other nice books - more than three arguments for a method is too many. Refactor them in to a parameter class. ;) )
AdminUcommerce (Admin, uCommerce) commented
Thank you for your suggestion! I have added it to our backlog, and will pass the idea by our Product Owner.